Snapcast: Add configuration options #1692
Conversation
Co-authored-by: Santiago Soto <[email protected]>
|
@whc2001 are you using pre commit ? |
Ah sorry I think it's not properly configured on the Windows machine I used to push |
Windows is not recommended for python development, especially not for MA development. |
|
Want to merge this now or do you want to adjust those category labels first ? |
The categories are already set but we are going to do the localization here, otherwise everything will remain without description |
|
@whc2001 I am already editing the frontend en.json |
|
Just got there, I'll check EDIT: Seems like my understanding of the lang file is a little off, what I did is something like "snapcast_server_built_in_initial_volume": {
"label": "Initial volume",
"description": "Volume assigned to new snapclients [percent]"
},But seems like your method is working well so I think we are good. |
|
Already got my latest change in music-assistant/frontend#674 and #1695 |
We have a new contributor, @whc2001 thank you for your help 🎉🎉
Some configuration options and some related details are fixed.
Fixes the problem with tts cutting off in the middle of the time, but there is still a problem with very short tts, like “Hi” where it just stops the music that is playing and comes back with the music after a few seconds and you never hear the chime or the “Hi”.